Provide Skaffold user-agent on update-checks and downloads #4964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cause update check to use util.Download() - cause util.Download() to use Skaffold user-agent - move HTTP related functions from util.go to new http.go - add simple tests
Codecov Report
@@ Coverage Diff @@
## master #4964 +/- ##
==========================================
+ Coverage 72.28% 72.30% +0.01%
==========================================
Files 360 361 +1
Lines 12595 12596 +1
==========================================
+ Hits 9104 9107 +3
+ Misses 2822 2818 -4
- Partials 669 671 +2
Continue to review full report at Codecov.
|
tejal29
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4963
Related: #582, #1260, #2723
Description
util.Download(), and causeutil.Download()to use Skaffold user-agent.User facing changes